NFS Export operations support for NFS for powerflex v4.0 #55
Conversation
There was a problem hiding this comment.
@KshitijaKakde, please rebase this branch with main as I see a couple of changes not reflexting here since the last merge.
Also fix the linting errors reported from github workflow.
There was a problem hiding this comment.
@KshitijaKakde Please address the below review comments. Thanks.
inttests/nfs_export_test.go
Outdated
| if nfsexport == nil { | ||
| return "" | ||
| } | ||
| fmt.Printf("filesystems[0].Name: %v", nfsexport[0].Name) |
There was a problem hiding this comment.
Please remove this print statement from integrations test.
inttests/nfs_export_test.go
Outdated
| return nfsexport[0].Name | ||
| } | ||
|
|
||
| // func TestGetFileSystemByName(t *testing.T) { |
There was a problem hiding this comment.
Please remove the commented code.
inttests/nfs_export_test.go
Outdated
| // } | ||
|
|
||
| func TestNFSExportByName(t *testing.T) { | ||
| // system := getSystem() |
There was a problem hiding this comment.
Please remove the commented code.
| assert.NotNil(t, system) | ||
|
|
||
| nfsName := fmt.Sprintf("%s-%s", "NFS", testPrefix+randString(8)) | ||
| nfsmodify := "NFS export modify testing" |
There was a problem hiding this comment.
Please remove this print statement from integrations test.
nfs_export.go
Outdated
| } | ||
|
|
||
| return respnfs, nil | ||
|
|
There was a problem hiding this comment.
Please remove this new line..
inttests/GOSCALEIO_TEST.env_example
Outdated
| @@ -14,6 +14,10 @@ GOSCALEIO_INSTALLATIONID=08bhsd7f9cfy890g | |||
| GOSCALEIO_NASSERVER=env8nasserver | |||
| GOSCALEIO_FILESYSTEM=env8FS | |||
|
|
|||
| # For NFSExport operations , enable these values | |||
| GOSCALEIO_NFSEXPORT=share1 | |||
| GOSCALEIO_FILESYSTEM_NFSEXPORT=twee-fs11 | |||
There was a problem hiding this comment.
please put a generic dummy value for GOSCALEIO_FILESYSTEM_NFSEXPORT
KshitijaKakde
force-pushed
the
nfs-export-changes
branch
from
725a84e to
2e1e7ec
Compare
There was a problem hiding this comment.
@KshitijaKakde I have added some review comments. Please address those.
types/v1/types.go
Outdated
| } | ||
|
|
||
| // CreateResponse defines struct for response | ||
| type CreateResponse struct { |
There was a problem hiding this comment.
can you rename this to NFSExportCreateResponse
| // NFSExport defines the struct for NFSExport | ||
| type NFSExport struct { | ||
| ID string | ||
| FileSystemID string `json:"file_system_id,omitempty"` |
There was a problem hiding this comment.
if you dont provide the json: tag it cannot parse the id.
Description
This PR includes changes for adding operation for NFS export for PowerFlex storage system v4.0
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your
Integration Test:
Unit Test