Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CreateSnapshotForFileSystem functionality for nfs-support #72

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Add CreateSnapshotForFileSystem functionality for nfs-support #72

merged 5 commits into from
Jul 24, 2023

Conversation

VamsiSiddu-7
Copy link
Contributor

Description

This pr adds the CreateSnapshotForFileSystem functionality for csi-powerflex nfs-support

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#763

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • TestResult
root@xxxxx:~/goscaleio# go test -v  -run ^TestCreateFileSystemSnapshot$ github.com/dell/goscaleio/inttests
=== RUN   TestCreateFileSystemSnapshot
--- PASS: TestCreateFileSystemSnapshot (52.45s)
PASS
ok      github.com/dell/goscaleio/inttests      52.764s

@VamsiSiddu-7 VamsiSiddu-7 merged commit f10386a into main Jul 24, 2023
khareRajshree pushed a commit that referenced this pull request Jul 24, 2023
@VamsiSiddu-7 @khareRajshree
Add CreateSnapshotForFileSystem functionality for nfs-support (#72)
419d168 
* add support for FileSystem Snapshot.

* add DeleteFilesystemby id functionality.

* add unit tests and integration tests.
@shanmydell shanmydell deleted the add-fs-snapshot branch October 16, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleyvjoy ashleyvjoy ashleyvjoy approved these changes

@khareRajshree khareRajshree khareRajshree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VamsiSiddu-7 @khareRajshree @ashleyvjoy