Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GetFsSnapshotByVolumeID functionality for nfs #77

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

VamsiSiddu-7
Copy link
Contributor

Description

GetFsSnapshotsByVolumeID gives the list of snapshots associated with the given filesytemid.
incase of any error it returns with an error.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#763

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • TestResults
root@xxxxx:~/goscaleio# go test -v -run ^TestGetFsSnapshotsByVolumeID$ github.com/dell/goscaleio/inttests
=== RUN   TestGetFsSnapshotsByVolumeID
--- PASS: TestGetFsSnapshotsByVolumeID (59.31s)
PASS
ok      github.com/dell/goscaleio/inttests      59.721s

@VamsiSiddu-7 VamsiSiddu-7 merged commit 657fcb1 into main Aug 4, 2023
@shanmydell shanmydell deleted the nfs-snaps-list branch October 16, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants