Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement in filesystem creation with nfs share #50

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sanketcoredge
Copy link

@sanketcoredge sanketcoredge commented Apr 8, 2024

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

shefali-malhotra and others added 2 commits April 8, 2024 12:31
Added method to modify file system and nfs share.
Updateed file system create model to accomodate nfs content with file system.
Added model to modify file system with nfs share.
Updated nfs share parameter model to accomodate adding comma separated list of hosts for different access types.
Updated file content response model to receive nfs share content and used size of file system.
Update nfs share content response model to receive comma separated list of hosts for different access types.
@sanketcoredge
Copy link
Author

@rajendraindukuri , @karthikk92 can you please review this PR?

@donatwork
Copy link

Please reference the GitHub issue in the PR and complete any requested items. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants