Update sidecarproxy to use skip certificate validation #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sahiba-Gupta
requested review from
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
coulof,
shaynafinocchiaro,
sharmilarama and
EvgenyUglov
as code owners
|
Can one of the admins verify this patch? |
|
test comment |
sharmilarama
previously approved these changes
Jul 11, 2022
sharmilarama
previously approved these changes
Jul 12, 2022
shaynafinocchiaro
previously approved these changes
Jul 13, 2022
|
run e2e test |
2 similar comments
|
run e2e test |
|
run e2e test |
|
Please sign all the commits. Thanks! |
Sahiba-Gupta
dismissed stale reviews from shaynafinocchiaro and sharmilarama
via
f203df1
tdawe
reviewed
Jul 19, 2022
|
run e2e test |
EvgenyUglov
approved these changes
Jul 21, 2022
atye
approved these changes
Jul 21, 2022
sharmilarama
approved these changes
Jul 21, 2022
|
e2e pass |
|
Merging this PR as e2e was successful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Authorization insecure related entities are renamed to skip_Certificate_Validation.
The TokenGetter and the StoragePoolCache use the same PowerFlex client which sets a login token behind the scenes if none is already set. The StoragePoolCache does not use the TokenGetter to set a token so sometimes we will see a race condition when the TokenGetter is updating and the StoragePoolCache is used.
The fix is to have the StoragePoolCache use the TokenGetter to set a token before making API calls.
Added an error check in the volumeDeleteHandler and fixed the image scan check (aquasecurity/trivy#2432).
Fixed vulnerability https://nvd.nist.gov/vuln/detail/CVE-2022-21698 by moving the Prometheus client to v1.11.1.
GitHub Issues
List the GitHub issues impacted by this PR:
| GitHub Issue # |
| dell/csm#368 |
| dell/csm#382 |
Checklist:
How Has This Been Tested?
I have tested it locally for powerflex, powerscale and powermax