Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build and unit test instructions. #131

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Add build and unit test instructions. #131

merged 3 commits into from
Aug 10, 2022

Conversation

donatwork
Copy link
Contributor

@donatwork donatwork commented Aug 8, 2022 •
edited by sharmilarama
Loading

Signed-off-by: Don Khan don.khan@dell.com

Description

Update README.md with build and unit test instructions. Add unit-test target to top level Makefile.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#357

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran build in clean repo and verified that build succeeds with new instructions.
  • Ran make unit-test in top of source tree.

@donatwork
Add build and unit test instructions.
8e3b849 
Signed-off-by: Don Khan <don.khan@dell.com>
@donatwork donatwork closed this Aug 9, 2022
@donatwork donatwork reopened this Aug 9, 2022
@donatwork
Update actions.yml
f760050 
Add missing env entry for DDOCKLE_HOST
@donatwork
Update allowedlist.yaml
f052447 
Add exceptions for now.
- vim is not used in the resiliency service itself (CVE-2022-2175)
- we are building with Go 1.18 so not sure why it is being flagged (CVE-2021-44716)
@donatwork donatwork merged commit 6d883ca into main Aug 10, 2022
@donatwork donatwork deleted the feature-414-dev-readme branch August 10, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharmilarama sharmilarama sharmilarama approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@atye atye atye approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donatwork @atye @shaynafinocchiaro @sharmilarama