Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for PowerScale topology #116

Merged
merged 2 commits into from
Jun 30, 2022
Merged

add support for PowerScale topology #116

merged 2 commits into from
Jun 30, 2022

Conversation

YianZong
Copy link
Contributor

@YianZong YianZong commented Jun 14, 2022

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#452

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A: UT
    image

  • Test B: manual testing
    image

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

Copy link
Collaborator

@hoppea2 hoppea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Yian, please hold off on merging any PRs to the main branch until after CSM 1.3 release (06/21)

@YianZong
Copy link
Contributor Author

Hi Yian, please hold off on merging any PRs to the main branch until after CSM 1.3 release (06/21)

Sure, @hoppea2

@YianZong
Copy link
Contributor Author

Hi @hoppea2 , can we resume PR review and merge for Q3 features now?

@hoppea2 hoppea2 dismissed their stale review June 22, 2022 12:21

ready for review now

@dell dell deleted a comment from atye Jun 22, 2022
@hoppea2
Copy link
Collaborator

hoppea2 commented Jun 22, 2022

Hi @hoppea2 , can we resume PR review and merge for Q3 features now?

@YianZong please go ahead, thank you for your patience

taohe1012
taohe1012 previously approved these changes Jun 23, 2022
forrestxia
forrestxia previously approved these changes Jun 24, 2022
sharmilarama
sharmilarama previously approved these changes Jun 24, 2022
Copy link
Collaborator

@sharmilarama sharmilarama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YianZong YianZong force-pushed the feature-334-PScaleTopo branch from 772b2a1 to aa663e9 Compare June 29, 2022 06:39
@sharmilarama
Copy link
Collaborator

run e2e test

@YianZong
Copy link
Contributor Author

Hi code owners, please kindly review and approve this PR. Thank you!

@YianZong YianZong merged commit e1a126f into main Jun 30, 2022
@YianZong YianZong deleted the feature-334-PScaleTopo branch June 30, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants