forked from crowbar/crowbar
-
Notifications
You must be signed in to change notification settings - Fork 6
Gating state machine
VictorLowther edited this page Nov 14, 2012
·
2 revisions
Unless otherwise indicated, gating will happen in terms of dev generated pull request bundles.
- Find pull request bundles.
- Verify that all pull requests in a bundle are present.
- Test that each pull request in the bundle merges cleanly into the branch it should merge into.
- Figure out what release/build combinations need to be tested based on the barclamps and branches referred to in the pull request bundle.
- Run any applicable pre-build unit tests for each release/build combination.
- Figure out what operating systems need to be tested for each release/build combination.
- Run a basic build and deploy test for each release/build/OS combination.
- Run smoketests for each barclamp involved
- If any of the above steps fail, downvote all the pull requests involved in the pull request bundle, otherwise upvote them and solicit code review.
- Once the automated parts of the state machine pass, the CI infrastructure will ask for code review on the Crowbar mailing list (or another mailing list created for that purpose).
- Once 2 people have indicated that they have reviewed and approved of the change, the code will be a candidate for automatic merging.
- Go through the same steps as part 1.
- Verify that that original submitter of the pull request bundle has a CLA in place.
- Merge.