Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md to use most current version of dat repo in instructions #34

Merged
merged 2 commits into from
May 10, 2023
Merged

Update README.md to use most current version of dat repo in instructions #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bf3293
Update README.md to use most current version of dat package in downlo…
JHibbard Apr 14, 2023
b1b9c55
Updated all references of to read as v0.0.2 of DAT tables drops the…
JHibbard May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ The tests cases are packaged into [releases](https://github.com/delta-incubator/
To download and unpack:

```
VERSION=0.0.1
VERSION=0.0.2
curl -OL https://github.com/delta-incubator/dat/releases/download/v$VERSION/deltalake-dat-v$VERSION.tar.gz
tar --no-same-permissions -xzf deltalake-dat-v$VERSION.tar.gz
```
Expand All @@ -27,10 +27,10 @@ All reader test cases are stored in the directory `out/reader_tests/generated`.
|-- expected
|-- latest
|-- table_version_metadata.json
|-- table_content.parquet
|-- table_content
|-- v1
|-- table_version_metadata.json
|-- table_content.parquet
|-- table_content
```

Each test case is a folder, named for its test. It contains:
Expand All @@ -52,7 +52,7 @@ Then for each test case:
2. Verify the metadata read from the Delta table matches that in the `table_version_metadata.json`. For example, verify that the connector parsed the correct `min_reader_version` from the Delta log. This step may be skipped if the reader connector does not expose such details in its public API.
3. Attempt to read the Delta table's data:
a. If the Delta table uses a version unsupported by the reader connector (as determined from `table_version_metadata.json`), verify an appropriate error is returned.
b. If the Delta table is supported by the reader connector, assert that the read data is equal to the data read from `table_content.parquet`. In order to make it easy to sort the tables for comparison, some tables have a column `pk` which is an ascending integer sequence.
b. If the Delta table is supported by the reader connector, assert that the read data is equal to the data read from `table_content`. In order to make it easy to sort the tables for comparison, some tables have a column `pk` which is an ascending integer sequence.

For an example implementation of this, see the example PySpark tests in `tests/pyspark_delta/`.

Expand Down