fix(python): reuse state in to_pyarrow_dataset
#2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
force-pushed
the
fix/reuse_table_state_pyarrow_dataset
branch
from
08a3a35
to
8617c80
Compare
|
Yup this fixes the issue 🥳 |
ion-elgreco
force-pushed
the
fix/reuse_table_state_pyarrow_dataset
branch
from
0b80b53
to
2695081
Compare
|
@ion-elgreco looks like it needs a rebase. Also just curious if you'll be making a release with this fix since it's such a huge performance win for an essential feature? |
ion-elgreco
force-pushed
the
fix/reuse_table_state_pyarrow_dataset
branch
from
bdcbfe2
to
b53643e
Compare
@wjones127 could you take a look at the PR? |
wjones127
reviewed
May 7, 2024
ion-elgreco
force-pushed
the
fix/reuse_table_state_pyarrow_dataset
branch
from
f5294a9
to
a5071b0
Compare
ion-elgreco
force-pushed
the
fix/reuse_table_state_pyarrow_dataset
branch
from
abe79d9
to
6cbcf01
Compare
wjones127
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reuse the state so we save time instead of reconstructing and verifying the state.