Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable RUF ruleset for ruff #2677

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

fpgmaas
Copy link
Contributor

@fpgmaas fpgmaas commented Jul 16, 2024

Description

This PR proposes to enable the RUF ruleset.

ruff check .

returned:

warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'ignore' -> 'lint.ignore'
  - 'select' -> 'lint.select'
  - 'isort' -> 'lint.isort'
deltalake/table.py:52:26: RUF100 [*] Unused `noqa` directive (unused: `F811`)
deltalake/writer.py:63:26: RUF100 [*] Unused `noqa` directive (unused: `F811`)
tests/pyspark_integration/test_write_to_pyspark.py:109:37: RUF010 [*] Use explicit conversion flag
Found 3 errors.
[*] 3 fixable with the `--fix` option.

So these were simply fixed with ruff check . --fix. #2673 handles the fixing of the outdated config.

@github-actions github-actions bot added the binding/python Issues for the Python package label Jul 16, 2024
@rtyler
Copy link
Member

rtyler commented Jul 16, 2024

I'm not familiar with the ruleset and the changes don't look problematic to me 🤷

@fpgmaas
Copy link
Contributor Author

fpgmaas commented Jul 16, 2024

CI/CD is failing due to this issue. Merging this PR will solve it for now.

@fpgmaas
Copy link
Contributor Author

fpgmaas commented Jul 16, 2024

@rtyler rebased, should be good now! Same for the other two PR's.

@rtyler rtyler enabled auto-merge (squash) July 18, 2024 07:39
@rtyler rtyler merged commit ab977e3 into delta-io:main Jul 18, 2024
21 checks passed
@fpgmaas fpgmaas deleted the chore/enable-ruf-ruleset branch July 18, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants