-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(python, rust): use require files #2809
Conversation
89a4c5a
to
7381060
Compare
7381060
to
ff8617f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2809 +/- ##
==========================================
- Coverage 72.66% 72.62% -0.04%
==========================================
Files 131 131
Lines 39962 40015 +53
Branches 39962 40015 +53
==========================================
+ Hits 29038 29062 +24
- Misses 9065 9088 +23
- Partials 1859 1865 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, not sure I understand this "feature" but that's no reason not to merge 😆
@rtyler this essentially reintroduces the option to skip reading all add actions and keeping that in memory for append only workloads. It also puts the necessary guard rails in place so people don't do operations where we need to know the add actions :p |
8b531e7
to
116f785
Compare
Description
The description of the main changes of your pull request
Follow up PR
Use tombstones flag as well
Related Issue(s)
Documentation