feat(rust): add operationMetrics to WRITE #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinmead
requested review from
wjones127,
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
gavinmead
force-pushed
the
write-metrics
branch
from
5b4d27e
to
8c3d793
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2838 +/- ##
==========================================
+ Coverage 72.49% 72.50% +0.01%
==========================================
Files 132 132
Lines 39892 40029 +137
Branches 39892 40029 +137
==========================================
+ Hits 28918 29023 +105
+ Misses 9151 9141 -10
- Partials 1823 1865 +42 ☔ View full report in Codecov by Sentry. |
rtyler
force-pushed
the
write-metrics
branch
from
8c3d793
to
c99c767
Compare
rtyler
previously approved these changes
Sep 3, 2024
this commit includes the following changes: * Defines a WriteMetrics struct * Writes metrics to app_metadata under key "operationMetrics" * Adds assertions to unit tests that get the latest commit info and check that metrics have been written * Updates a few test assertions that changed because the commit info has more metadata.
rtyler
force-pushed
the
write-metrics
branch
from
c99c767
to
526c0f3
Compare
rtyler
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR contains the following:
Related Issue(s)
closes #1992