Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert last checkpoint json keys to camelCase #2889

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

feniljain
Copy link
Contributor

@feniljain feniljain commented Sep 19, 2024

Description

While storing _last_checkpoint delta-rs does not convert json keys to camel case, but protocol mentions they should be in camelCase, fix exactly that :)

Related Issue(s)

Fixes delta-incubator/delta-kernel-rs#326

Documentation

Issue description is nicely documented :)

Output screenshots:

Tested with local crate copy and created a table

Screenshot 2024-09-19 at 3 55 14 PM

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.41%. Comparing base (b3b23be) to head (3411eb6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2889      +/-   ##
==========================================
+ Coverage   72.37%   72.41%   +0.04%     
==========================================
  Files         133      133              
  Lines       40238    40253      +15     
  Branches    40238    40253      +15     
==========================================
+ Hits        29124    29151      +27     
+ Misses       9239     9237       -2     
+ Partials     1875     1865      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco
Copy link
Collaborator

@feniljain can you add a test?

@feniljain
Copy link
Contributor Author

feniljain commented Sep 19, 2024

Hey, I have added a small test. It's hacky, and I am not sure if you are looking for a different type of test. If yes, do help me out by pointing me to it 😅

@ion-elgreco ion-elgreco added this pull request to the merge queue Sep 20, 2024
Merged via the queue into delta-io:main with commit 55a19f6 Sep 20, 2024
21 checks passed
@feniljain feniljain deleted the fix-protocol-casing branch September 23, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in the last checkpoint metadata field naming: snake_case used instead of camelCase
2 participants