[Spark] Delta Tables with Unity Catalog (UC) as Commit Coordinator #3837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...age/src/main/java/io/delta/storage/commit/uccommitcoordinator/UCCommitCoordinatorClient.java
Outdated
Show resolved
Hide resolved
...age/src/main/java/io/delta/storage/commit/uccommitcoordinator/UCCommitCoordinatorClient.java
Show resolved
Hide resolved
...age/src/main/java/io/delta/storage/commit/uccommitcoordinator/UCCommitCoordinatorClient.java
Outdated
Show resolved
Hide resolved
...age/src/main/java/io/delta/storage/commit/uccommitcoordinator/UCCommitCoordinatorClient.java
Outdated
Show resolved
Hide resolved
storage/src/main/java/io/delta/storage/commit/uccommitcoordinator/UCTokenBasedRestClient.java
Show resolved
Hide resolved
prakharjain09
approved these changes
Nov 6, 2024
| } | ||
| } | ||
| // Initialize table ID for the calling test | ||
| // tableUUID = UUID.randomUUID().toString |
There was a problem hiding this comment.
It looks like we have tableUUID as a class member so we can remove this comment (lines 140 - 141)?
sumeet-db
force-pushed
the
uc_oss_1
branch
3 times, most recently
from
237165e
to
c1af990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR add supports for Delta tables in
delta-sparkwith Unity Catalog (UC) as the Commit Coordinator. This feature enables UC to act as the commit coordinator for Delta tables, providing atomic commit operations and seamless integration between Delta tables and Unity Catalog. The system will use UC as the commit coordinator whendelta.coordinatedCommits.commitCoordinator{-preview}is set tounity-catalogin the Delta table properties.UC will maintain table metadata and track unbackfilled commits. UC will also ensure atomic commits and handle commit conflicts.
See Delta Coordinated Commits RFC or PROTOCOL.md for more information on the coordinated commits and its benefits.
Feature Request: #3836
Design Doc
How was this patch tested?
New UTs in the PR
Does this PR introduce any user-facing changes?
No