Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use default iroh relays #5591

Open
link2xt opened this issue May 17, 2024 · 3 comments · May be fixed by #5609
Open

Do not use default iroh relays #5591

link2xt opened this issue May 17, 2024 · 3 comments · May be fixed by #5609

Comments

@link2xt
Copy link
Collaborator

link2xt commented May 17, 2024

We should not use default iroh relays, but only connect to other peers that have relays if we don't have our own relay:

// FIXME: this should be RelayMode::Disabled instead.
// Currently using default relays because otherwise Rust tests fail.
RelayMode::Default

However, disabling it now will break Rust tests because they don't connect to IMAP and cannot get the relay address from IMAP METADATA. Tests should be moved into Python deltachat-rpc-client first.

@link2xt link2xt added the bug Something is not working label May 17, 2024
@Septias
Copy link
Contributor

Septias commented May 20, 2024

We discussed irl that just using a #[cfg(test)] flag should be enough, no?

@Septias
Copy link
Contributor

Septias commented May 20, 2024

I still think we should use the default relay because communication becomes impossible if no member in a group has a chatmail server. (no relay and direct addresses => no direct connection). For us, everyone uses chatmail, so we don't really care, but I don't know how the situation is in Cuba. If you are really concerned about security, you can make sure that you yourself are on a chatmail server or disable realtime completely. @hpk42 @r10s @adbenitez

@Septias Septias linked a pull request May 20, 2024 that will close this issue
@hpk42
Copy link
Contributor

hpk42 commented May 22, 2024 via email

@link2xt link2xt removed the bug Something is not working label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants