fix: Use "ir.testrun.org" as default iroh relay #5609
Conversation
Septias
changed the title
src/peer_channels.rs
Outdated
| RelayMode::Default | ||
| } | ||
| #[cfg(not(test))] | ||
| RelayMode::Disabled |
There was a problem hiding this comment.
you should at least print a big warning in this case, given that iroh won't work in this setup with deltachat currently
There was a problem hiding this comment.
Commented about this in the issue aswell
link2xt
force-pushed
the
debug-iroh-2
branch
5 times, most recently
from
9e14e69
to
37c771d
Compare
Septias
changed the title
|
The JSON-RPC python tests are failing because we can't set [cfg(test)] there. Maybe we can compile json-rpc-server with |
src/peer_channels.rs
Outdated
| } | ||
| #[cfg(not(test))] | ||
| RelayMode::Custom(RelayMap::from_url( | ||
| Url::parse("ir.testrun.org").unwrap().into(), |
There was a problem hiding this comment.
Should be https://iroh.testrun.org:4443
There was a problem hiding this comment.
Parsing plain URL without https:// results in "called Result::unwrap() on an Err value: RelativeUrlWithoutBase"
|
What's the status of this PR? The code looks good to me, but I didn't really follow iroh developments. I rebased in order to test whether the tests pass. |
|
There is still discussion in the related issue |
|
ir.testrun.org simply does not exist and currently used chatmail server points to iroh.testrun.org:4443 from metadata so fallback is not tested by CI. |
close #5591