sql: enable shared cache #2356
Merged
sql: enable shared cache #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark of opening the database and searching for "hello" 10 times in my Desktop database: |
|
nice graphics! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #2355, which should be merged in first.
Fixes #2353
I am not sure about safety of
PRAGMA read_uncommitted=1;, but it is suggested by https://sqlite.org/sharedcache.html and I get "table locked" errors otherwise. I think it should not cause significant issues because we usually don't commit many rows in a single transaction and don't rely on them being either written or not at the same time during reading.