sql: set PRAGMA synchronous=normal #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was set in `sqlx` code, but not in `rusqlite` mode. synchronous=FULL makes benchmark that write to the database a lot slower.
|
This seems to be the main reason for slowdown in #2380 (comment) |
Comparison of this branch to latest sqlx codeCreate 1 account
Create 100 contacts and read it 1000 times
Create 500 contacts
Search "hello" in my database
|
r10s
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was set in
sqlxcode, but not inrusqlitemode.synchronous=FULL makes benchmark that write to the database a lot slower.