feat: Add xstore contact to every account

[Septias]

This PR adds a database migration that creates the xstore contact for every account. New accounts are affected as well as already existing accounts.

closes #5855

[link2xt]

What does origin 6710886 mean?

[link2xt]

Also the tests fail and I'm not sure how useful is the contact without a key.

One idea to fix this was to have an API to import vCard and mark imported contacts as verified, then import this from the UI side rather than with migration so ArcaneChat can import other bots as well and we don't hardcode xstore into the core.

[Simon-Laux]

I thought the latest idea was to let the bot die because it was buggy or sth. and integrate a "store" directly into the attachment menu. Did something change?

[adbenitez]

I thought the latest idea was to let the bot die because it was buggy or sth. and integrate a "store" directly into the attachment menu. Did something change?

even if we go for something else, I would not say that just because something "is buggy" the better solution is to let it die and build something similar from scratch and hope the new iteration would have no bugs!?
the main reason to go for an integrated store without bot is because:

• it is faster,
• doesn't leak your email address and crypto identity and metadata of apps you downloaded to a 3rd party
• better UX without the complexities of a bot + webxdc in a chat

that said, the UI that the bot has is even more ready than the one in the web version we have and it just needs some improvements, if making the whole thing from scratch would be simpler and produce a more simple and maintainable code base I don't know, but the best would be if any UI that we decide to use could work both as a web site and as a webxdc, that could be used by the existing bot and by Delta Chat clients as integrations for the clients that don't want to just download the json metadata and implement native UI for the app picker, similar to how the bots index is a bot and a website at the same time with the same code

more back to present time: the question is what is easier? just add the store bot so users can access mini-apps in the mean time or add the new picker in a few hours?? the picker would need some time, and in the meantime it is good that the users can use the xstore bot at least

[link2xt]

xstore works fine and gets updates automatically, and accessing it via email without direct HTTP requests is useful. We don't even have the store in the attachment menu now.

But anyway, the original issue is about adding "invite link" because it should result into sending the message back immediately when you scan the QR code. Having a contact "xstore" in the contact list without any explanation that has empty chat does not help, users will likely not write to such bot first.

[Simon-Laux]

I did not say that this was my opinion, just what I heard from holger. my question was if consensus changed / what the current consensus is.

now back to the topic -> don't call it x-store, people will not understand that name, it's name should be more descriptive and less technical.

But anyway, the original issue is about adding "invite link" because it should result into sending the message back immediately when you scan the QR code.

device message or fake contact list item in the UI? or sth. else?

[adbenitez]

xstore works fine and gets updates automatically, and accessing it via email without direct HTTP requests is useful. We don't even have the store in the attachment menu now.

exactly keeping updates would be then needed to be done by the client pinging some random website to fetch metadata, the website could be blocked and if we use github link that would count as anti-feature depending in non-free network

now back to the topic -> don't call it x-store, people will not understand that name, it's name should be more descriptive and less technical.

+1 I really don't like the xstore name, also the bot doesn't even has a nice display name

[adbenitez]

But anyway, the original issue is about adding "invite link" because it should result into sending the message back immediately when you scan the QR code. Having a contact "xstore" in the contact list without any explanation that has empty chat does not help, users will likely not write to such bot first.

I think it still helps to have the contact added (with avatar and all) what about this solution that would not require any UI changes:
when the user clicks in the contact in the contact list, and the UI calls createChat() for this contact because there is no chat yet, core then will cause a secure join link scan for this contact and create the chat that way instead the normal chat creation

[Simon-Laux]

can't we just hardcode the initial current public key / peerstate for the x store bot?
If you send a message to wrong key it still goes out with chatmail and you get the unknown key response and the new key.

[iequidoo]

One idea to fix this was to have an API to import vCard and mark imported contacts as verified, then import this from the UI side rather than with migration so ArcaneChat can import other bots as well and we don't hardcode xstore into the core.

import_vcard() is already here, the only thing is that it doesn't mark the contact as verified, but we can add a flag for this. Then, maybe don't hardcode too much, but just add a device message with a bot vCard attachment? This could be done upon an initial setup and once for already existing setups as well, and also when smth new happens with the official webxdc store.

[r10s]

but just add a device message with a bot vCard attachment?

after initial installation, the device chat is for importing onboarding information eg. how to get in contact with others. we do not want to clutter this chat with too many information - this is also the reason, we do not add a "changes" device message there after initial installation.

therefore, an entry in the contact list is much less cluttering ui and distracting; it also feels quite natural, and it is also okay, if the user does not discover it in the first minutes. let's better stay with that idea ¹

Footnotes

1. under the hood a vcard can be still used - eg. have one in the assets folder and a function that adds that to the contact list (not: create a chat), including key, avatar, bio. but thats only technical details, maybe other ways are easier. ↩

[Septias]

I think giving the contact a proper display name like "Deltachat Apps" or something more descriptive together with a chat that has the xstore icon and a status explaining the contact should make the use already quite obvious for an unknowing user.
Other than that I quite like @iequidoo's Idea with some device message and vcard, because that also helps users discover the app service.

[iequidoo]

Still, i think hardcoding such things at Core level isn't good, i'd prefer to add some API for this, maybe even put a bot vCard to the core repo, but it should be integrated at the apps' level. E.g. we don't have nine.testrun.org anywhere in Core except for the tests and provider db and that's rather good.

Secondly, it should be clear to the user that this bot isn't just one more verified contact, it should be highlighted somehow. Otherwise i can name myself "xstore bot" and i won't be much different from the real bot for my contacts. Though the same problem already exists for "Saved Messages" and "Device Messages", so it's not critical.

[Septias]

If I see it correctly, the sentiment is that we generally want the bot contact but it should also have the icon. Maybe we can even add some explanatory message to the chat preemptively. Other than that we want QR codes that when scanned directly put you in a chat with the requested app. I would put that to a follow up PR