-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: correct DC_CERTCK_ACCEPT_* values and docs #6176
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
f958376
to
8b15c14
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Still need to run |
did so.
|
65856df
to
1a85b7c
Compare
k, i disarmed the potentially harmful part of this PR: existing constant stay unchanged, only the missing one is added. this only leads to some weird names :) if implementation do nothing, things stay as before, and things can be improved without stress, without generating blocking issues. when this PR is merged, we should file issues on desktop/iOS that only DC_CERTCK_ACCEPT_INVALID must be written and DC_CERTCK_ACCEPT_INVALID as well as DC_CERTCK_ACCEPT_INVALID_CERTIFICATE must be accepted on reading 1 Footnotes
|
Co-authored-by: iequidoo <117991069+iequidoo@users.noreply.github.com>
this PR changes
DC_CERTCK_ACCEPT_*
to the same values in cffi as rust does. and regards the same values as deprecated afterwardsthere is some confusion about what is deprecated and what not, see deltachat/deltachat-android#3408
iOS needs to be adapted as it was following the docs in the CFFI before, same desktop. both need to be graceful on reading and strict on writing.
this PR is considered harmful, so we should not merge that in during 1.48 release, there is no urgency, things are fine (wondering if it isn't even worth the effort, however, having different values and deprecations is a call for trouble in the future ...)