Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy over some docs as requested in the associated issue. #6193

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

Septias
Copy link
Collaborator

@Septias Septias commented Nov 10, 2024

Copy over some docs as requested in the associated issue.

close #5503

@Septias Septias changed the title Sk/add_jsonrpc_docs Copy over some docs as requested in the associated issue. Nov 10, 2024
Copy over some docs as requested in the associated issue.

close #5503
Copy link
Member

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than before 👍.

Note / Thought / nitpick / idea: Maybe deltachat.h has additional information that is even better than the core doc comments?

@Septias
Copy link
Collaborator Author

Septias commented Nov 10, 2024

deltachat.h has a bit more explanations, but different structure so I think porting that is too much effort

@Septias Septias merged commit 6b2d49a into main Nov 10, 2024
37 checks passed
@Septias Septias deleted the sk/add_jsonrpc_docs branch November 10, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: copy qr struct doc comments to jsonrpc qr code struct
2 participants