feat: Mark reactions as IMAP-seen in marknoticed_chat() (#6210) #6213
Conversation
|
Since you marked it as a draft, I take it that it's not ready to be reviewed yet? |
When a reaction notification is shown in the UIs, there's an option "Mark Read", but the UIs are unaware of reactions message ids, moreover there are no `msgs` rows for reactions in the core, so the UIs just call `marknoticed_chat()` in this case. We don't want to introduce reactions message ids to the UIs (at least currently), but let's make received reactions usual messages, just hidden, so that the existing `\Seen` flag synchronisation mechanism works for them, and mark all incoming hidden messages in the chat as seen in `marknoticed_chat()`. It's interesting that sent out reactions are already hidden messages, so this change mostly just unifies things.
iequidoo
force-pushed
the
iequidoo/seen-reactions
branch
from
a089199
to
b71c681
Compare
Now it's ready and seems working, but probably needs more tests. Was a draft because i needed to optimise out saving unnecessary columns to db. It's interesting that sent out reactions were already hidden messages, didn't know about that. |
|
Ideally there will be a test that marks a reaction as seen on one device and checks that a MsgsNoticed event is emitted on another device (and check that the test fails without this PR here), in addition to the unit tests. If this is not feasible, would be good to manually test that this event is sent. Edit: If, during testing, it turns out that it's harder to do than expected, it would be fine to just ignore the issue, see deltachat/deltachat-android#3377 (comment) |
See commit messages.
Close #6210
For
DC_CHAT_ID_ARCHIVED_LINKthis does nothing, marking all reactions as seen in the archive doesn't seem useful.mark_old_messages_as_noticed()only marks reactions asInNoticed, this function is called fromimapwhen new messages arrive, so it is anyway called on all devices, no synchronisation is needed.DONE: