feat: webxdc notify #6230
Open
feat: webxdc notify #6230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avoids snake_case and camelCase confusion :)
r10s
force-pushed
the
webxdc-notifiy
branch
2 times, most recently
from
df4466c
to
1a8cc10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds support for the property
update.notify; the property can be set to an array of addresses 1core emits then the event
IncomingMsginstead ofMsgsChanged, resulting in all UIs to display a system notification, maybe even via PUSH. no further changes on UI should be needed; UIs could, as an enhancement, show the webxdc icon in the notification, of course.as text/sender/icon, the existing
update.infois used: the message is no secret and should be visible to all group members as usual, to not break the UX of having same group messages on all devices of all users - as known already from the normal messages. also, that way, there is no question what happens if user have disabled notifications (they will just see an informational message)doc counterpart at webxdc/website#90
closes #6217
Footnotes
addresses come in either via the payload as currently or as an explicit sender in the future - this does not affect this PR. same for translations, see discussions at webxdc notifications (M2) #6217 and [Tracking issue] Webxdc notifications #6097 ↩