Use Message.file_name as the proposed filename in Save As dialog rather than the source basename

[link2xt]

Currently the source basename is used as a proposed filename for save as dialog:

deltachat-desktop/src/main/ipc.ts

Line 136 in 7b5032a

defaultPath: join(base_path, basename(source)),

This is usually a mangled filename like store-890578782.xdc if the file with this filename was shared more than once, and there is a plan to use completely random filenames or hashes for the blobs stored in the blobdir: deltachat/deltachat-core-rust#4309

If Desktop uses Message.file_name instead, a single core change will improve the Save As dialog so right-clicking a media file and selecting Save As will always open the dialog with a store.xdc proposed name instead.

[farooqkz]

if the file with this filename was shared more than once

Can you please elaborate? Like if I forward the file from a group to another one?

[farooqkz]

Explanation from @Simon-Laux :

sending the same file in multiple chats without using forward will alter the filename, core wants to change that in the future so desktop should be ready for it or sth like that

[link2xt]

dc_msg_get_filename() and Message.file_name are not even new APIs, Desktop could have used them from the beginning instead of using basename() on a file path.