Skip to content

Commit

Permalink
[Packaging] Pinned Pyinstaller to v4.10 and readme update
Browse files Browse the repository at this point in the history
Pin Pyinstaller to latest v4.x until issue of aborting upon missing typelibs for various unbuilt gst-modules can be properly investigated and resolved. Specific error for one of the modules being:

`36738 INFO: Loading module hook 'hook-gi.repository.Gst.py' from 'C:\\hostedtoolcache\\windows\\Python\\3.9.13\\x64\\lib\\site-packages\\PyInstaller\\hooks'...
Traceback (most recent call last):
  File "<string>", line 7, in <module>
gi.repository.GLib.GError: g-irepository-error-quark: Typelib file for namespace 'Gst', version '1.0' not found (0)
36870 ERROR: gi repository 'GIRepository 2.0' not found. Please make sure corresponding package is installed.
Traceback (most recent call last):
  File "<string>", line 4, in <module>
  File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\site-packages\gi\__init__.py", line 139, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Gst not available`

Added `--no-index` to ensure pip doesn't install from Pypi

Closes: #386
  • Loading branch information
mhertz authored and cas-- committed Jun 13, 2022
1 parent 6a10e8f commit ae3fbcc
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,12 @@ jobs:
- name: Install Python dependencies
run: >
python -m pip install --find-links="C:\GTK\release\python" pycairo PyGObject
python -m pip install --no-index --find-links="C:\GTK\release\python" pycairo PyGObject
python -m pip install
twisted[tls]==22.4.0
libtorrent==${{ matrix.libtorrent }}
pyinstaller
pyinstaller==4.10
pygame
-r requirements.txt
Expand Down
8 changes: 5 additions & 3 deletions packaging/win/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@ Instructions for building the Deluge NSIS Installer for Windows Vista/7/8/8.1/10
== Build Steps ==

1. Build and Install Deluge on Windows.
2. Run the pyinstaller from the deluge\packaging\win directory.spec:
2. Run pyinstaller from the deluge\packaging\win directory:

`pyinstaller --clean delugewin.spec --distpath .\packaging\win\freeze`
`pyinstaller --clean delugewin.spec --distpath freeze`

The result is a PyInstaller version of Deluge in `packaging\win\freeze`.

3. Run the NSIS script:
3. Run the NSIS scripts:

`python setup_nsis.py`

64-bit python:

Expand Down

0 comments on commit ae3fbcc

Please sign in to comment.