-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support announcing to all trackers of the same tier. #319
base: develop
Are you sure you want to change the base?
Conversation
Looks good. |
d31b619
to
6211cb2
Compare
Ah yes, good plan. I haven't tested those of course, but I've been using this patch otherwise for quite some time. |
Can I just clarify what implementation we trying to achieve here with regards tracker announcing since there are two options:
I have updated the Trac ticket with relevance discussion points but my take on this is to use the latter |
@@ -85,6 +85,7 @@ | |||
'max_active_downloading': 3, | |||
'max_active_limit': 8, | |||
'dont_count_slow_torrents': False, | |||
'announce_to_all_trackers': True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should default to False
I'd have gone for the former, it makes a lot more sense to me as you can configure exactly which trackers are fallback, and makes more logical sense to treat trackers set as the same priority in the list, well, the same. It seems they're taking an entirely different definition to the tiers though, which if selecting this option would surprise me as a user as I'd have different expectations. Perhaps a mouseover if the latter is used? |
@cas-- I'm not specifically attached to the one way of doing this, I do have a preference but in the end either way will allow me to do what I want (without locally patching.) If you have wording suggestions for mouseover text or whatnot, that'd be appreciated too (unless you want to just adapt it.) |
This fixes bug http://dev.deluge-torrent.org/ticket/1395