Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebUI] edit trackers for multiple torrents #418

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

xuefer
Copy link
Contributor

@xuefer xuefer commented Apr 11, 2023

No description provided.

Signed-off-by: Xuefer H <xuefer@gmail.com>
@cas--
Copy link
Member

cas-- commented Apr 26, 2023

There is an existing Trac ticket for editing trackers on multiple torrents, does this handle the use-cases defined there? I am concerned about unexpected outcomes e.g. user not noticing multiple torrents selected etc..

@xuefer
Copy link
Contributor Author

xuefer commented Apr 26, 2023

trac ticket: https://dev.deluge-torrent.org/ticket/2047

your concern is not solved by this pull request, but the "move storage" accept and works on multiple selected torrents

'search and replace' is better way than this pull request, IF it's implemented in the UI (gtk/web)

@cas--
Copy link
Member

cas-- commented Apr 29, 2023

Yeah I think text or confirmation popup to warn that the action will replace all trackers for multiple torrents is needed

@WrayOfSunshine
Copy link

FWIW "search/replace" doesn't resolve at least one use case I have - I swapped from a different torrent client, and ALL the torrents from a private tracker got their tracker list wiped out in the process. Since I wasn't keeping backup torrent files, I had just copied the 'backups' from that program's app data folder, but those backups didn't contain the tracker list. I have all of those torrents siloed into a specific label now, but now I need to add tracker data to each one by hand :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants