Update gvsbuild stack and allow releases using both a newer stack, as well as using the latest versions that still support python 3.7. #3
Conversation
Maybe this way we can fix adwaita being dumb and failing because gtk isn’t yet installed?
.github/workflows/release.yml
Outdated
| @@ -72,12 +72,12 @@ jobs: | |||
|
|
|||
| - name: Current Date | |||
| id: date | |||
| run: echo "::set-output name=date::$(date +'%Y-%m-%d')" | |||
| run: echo "date=$(date +'%Y-%m-%d')" >> GITHUB_OUTPUT | |||
There was a problem hiding this comment.
Does this work without a dollar prefix? e.g. $GITHUB_OUTPUT
There was a problem hiding this comment.
As a whole it was working, if you look at the CI for my deluge PRs, but it shouldn't be. Well caught.
There was a problem hiding this comment.
Fixed in commit below
.github/workflows/release.yml
Outdated
| with: | ||
| repository: wingtk/gvsbuild | ||
| repository: ${{ github.repository_owner }}/gvsbuild |
There was a problem hiding this comment.
This won't work unless we fork it here so what about an input var that defaults to wingtk?
There was a problem hiding this comment.
Indeed. This is because I had to make a few patches to get everything working.
There was a problem hiding this comment.
If you look at my fork, you'll see the heaviest patching was for making an updated environment that still works with python 3.7. However, there was also a patch on the newer branch to get around a bug in glib2
There was a problem hiding this comment.
Ok, so I just consolidated everything under a single "latest" release. It uses my fork for the 3.7 version and the original wingtk repository for the 3.9 and 3.10 builds. I've removed inputs entirely for the workflow.
Lord-Kamina
force-pushed
the
main
branch
7 times, most recently
from
1d49c26
to
f6b961e
Compare
Use the fork belonging to whoever is running this instead
|
As I mentioned on discord, it seems the issue with glib2 had nott in fact been fixed. Or more accuratly, it was fixed in glib-2.81.0 but gvsbuild is still using 2.80.4. So, I made the following modifications:
|
This is preparatory work for some PRs I intend to send over at the deluge repo.
The end objective is to update the deluge CI/CD process, which itself is preparatory work for some actual improvements to deluge.