Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow routes with colons #175

Closed
morigs opened this issue Jan 13, 2021 · 1 comment · Fixed by #176
Closed

Allow routes with colons #175

morigs opened this issue Jan 13, 2021 · 1 comment · Fixed by #176

Comments

@morigs
Copy link
Contributor

morigs commented Jan 13, 2021 •
edited
Loading

Currently there is no way to define a route with colon in the path (expect regular expressions of course)
Some companies require following the Google API conventions which use colon
It seems Express.js allows that by using doubled colon or by wrapping colon in the brackets
I believe Fastify should also have a way to achieve this behavior
@mcollina
Copy link
Collaborator

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

morigs added a commit to morigs/find-my-way that referenced this issue Jan 13, 2021
@morigs
Add double colon handling (delvedor#175)
3f59265
@morigs morigs mentioned this issue Jan 13, 2021
Merged
ivan-tymoshenko added a commit to ivan-tymoshenko/find-my-way that referenced this issue Dec 20, 2021
@ivan-tymoshenko
add additional tests (delvedor#175)
a458be1
ivan-tymoshenko added a commit to ivan-tymoshenko/find-my-way that referenced this issue Dec 20, 2021
@ivan-tymoshenko
add additional tests (delvedor#175)
2b2f7c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add double colon handling (support for paths with colons) morigs/find-my-way
2 participants
@mcollina @morigs