Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzz logging level #1569

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Fuzz logging level #1569

merged 3 commits into from
Jun 26, 2024

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Jun 26, 2024

  • Don't pause on lp_rate failure in local fuzz runs (still log to rollbar)
  • Change default logging level to ERROR instead of CRITICAL
  • Change logging of rust calc_max_* errors from to WARNING instead of ERROR

There are still errors being logged as ERROR that we expect, e.g., InsufficientLiquidity or CircuitBreakerTriggered on a contract call. Need follow up PR to handle these, or log as less severe.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.11%. Comparing base (e8cd96c) to head (02b8909).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1569      +/-   ##
==========================================
- Coverage   81.32%   81.11%   -0.22%     
==========================================
  Files          98       98              
  Lines        7100     7100              
==========================================
- Hits         5774     5759      -15     
- Misses       1326     1341      +15     
Flag Coverage Δ
unittests 81.11% <100.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slundqui slundqui merged commit 887d70c into delvtech:main Jun 26, 2024
5 checks passed
@slundqui slundqui deleted the fuzz-logging-level branch June 26, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants