Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy steth hyperdrive #1570

Merged
merged 14 commits into from
Jun 27, 2024
Merged

Deploy steth hyperdrive #1570

merged 14 commits into from
Jun 27, 2024

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Jun 26, 2024

This PR adds a steth hyperdrive deployment to agent0.

NOTE there exists an error with converting to/from lido shares that needs to be fixed. test_funding_and_Trades currently breaks for the steth deployment, which requires the fix for this to pass.
#1545

@slundqui slundqui mentioned this pull request Jun 26, 2024
3 tasks
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 97.95918% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.68%. Comparing base (887d70c) to head (d448164).
Report is 110 commits behind head on main.

Files with missing lines Patch % Lines
...t0/core/hyperdrive/interactive/local_hyperdrive.py 92.85% 1 Missing ⚠️
src/agent0/ethpy/hyperdrive/deploy.py 98.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1570      +/-   ##
==========================================
+ Coverage   81.43%   81.68%   +0.24%     
==========================================
  Files          98       98              
  Lines        7100     7163      +63     
==========================================
+ Hits         5782     5851      +69     
+ Misses       1318     1312       -6     
Flag Coverage Δ
unittests 81.68% <97.95%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dpaiton dpaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for doing this!

@slundqui slundqui merged commit dab10b2 into delvtech:main Jun 27, 2024
5 checks passed
@slundqui slundqui deleted the deploy-steth branch June 27, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants