Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fuzz fixes #1582

Merged
merged 21 commits into from
Jun 28, 2024
Merged

Various fuzz fixes #1582

merged 21 commits into from
Jun 28, 2024

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Jun 28, 2024

  • Checkpoint bot logs warnings when retrying, and logs criticals if it fails 10 times in a row.
  • Invariant check script checks every block.
  • Running invariance checks asynchronously.
  • Each invariance check controls what log level to log at in rollbar.
  • Changing check_checkpointing_should_never_fail to check_previous_checkpoint_exists, which ensures the previous checkpoint always exists.
  • LP share price check throws warning if price is up past threshold, throws critical if price is down past threshold.
  • Removing initial lp profitable check.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 70.45455% with 26 lines in your changes missing coverage. Please review.

Project coverage is 82.35%. Comparing base (36d3b1d) to head (5d03bb5).
Report is 101 commits behind head on main.

Files with missing lines Patch % Lines
...c/agent0/hyperfuzz/system_fuzz/invariant_checks.py 73.43% 17 Missing ⚠️
src/agent0/hyperfuzz/system_fuzz/run_fuzz_bots.py 33.33% 6 Missing ⚠️
...gent0/ethpy/hyperdrive/interface/read_interface.py 83.33% 2 Missing ⚠️
src/agent0/core/hyperdrive/interactive/chain.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1582      +/-   ##
==========================================
+ Coverage   82.01%   82.35%   +0.34%     
==========================================
  Files          98       98              
  Lines        7239     7256      +17     
==========================================
+ Hits         5937     5976      +39     
+ Misses       1302     1280      -22     
Flag Coverage Δ
unittests 82.35% <70.45%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

scripts/checkpoint_bots.py Outdated Show resolved Hide resolved
Copy link
Member

@dpaiton dpaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for turning around these TODOs so quickly. I think we should talk about testing this out on a mainnet fork w/ fuzz bots. We should do things like underfund the checkpoint bot and make sure discord pings the critical error. We could also spin up anvil w/ a known insolvent pool state and run the checkpoints to verify errors show up.

@slundqui slundqui merged commit 6dde701 into delvtech:main Jun 28, 2024
4 of 5 checks passed
@slundqui slundqui deleted the fuzz-fixes branch June 28, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants