-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fuzz fixes #1582
Various fuzz fixes #1582
Conversation
…th markets to always return lido shares
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1582 +/- ##
==========================================
+ Coverage 82.01% 82.35% +0.34%
==========================================
Files 98 98
Lines 7239 7256 +17
==========================================
+ Hits 5937 5976 +39
+ Misses 1302 1280 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks for turning around these TODOs so quickly. I think we should talk about testing this out on a mainnet fork w/ fuzz bots. We should do things like underfund the checkpoint bot and make sure discord pings the critical error. We could also spin up anvil w/ a known insolvent pool state and run the checkpoints to verify errors show up.
check_checkpointing_should_never_fail
tocheck_previous_checkpoint_exists
, which ensures the previous checkpoint always exists.