Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up rollbar output #1589

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Jul 1, 2024

  • No longer printing trace if it doesn't contain error message (too much info)
  • Adding transaction hash if transaction went through with status == 0
  • Adding arg to orig exception showing result of retry preview for status == 0

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.54%. Comparing base (01f3f22) to head (3370f92).
Report is 96 commits behind head on main.

Files with missing lines Patch % Lines
src/agent0/ethpy/base/transactions.py 20.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1589      +/-   ##
==========================================
- Coverage   81.68%   81.54%   -0.14%     
==========================================
  Files          98       98              
  Lines        7289     7295       +6     
==========================================
- Hits         5954     5949       -5     
- Misses       1335     1346      +11     
Flag Coverage Δ
unittests 81.54% <25.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slundqui slundqui merged commit a6d9e2b into delvtech:main Jul 1, 2024
4 of 5 checks passed
@slundqui slundqui deleted the rollbar-error-cleanup branch July 1, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants