Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a bug where precision was getting lost in event -> db pipeline #1621

Merged
merged 11 commits into from
Jul 23, 2024

Conversation

slundqui
Copy link
Contributor

No description provided.

@slundqui slundqui enabled auto-merge (squash) July 23, 2024 20:08
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.48%. Comparing base (7bb4141) to head (00ec5fe).
Report is 78 commits behind head on main.

Files with missing lines Patch % Lines
...c/agent0/ethpy/hyperdrive/interface/_event_logs.py 78.94% 4 Missing ⚠️
src/agent0/chainsync/db/hyperdrive/convert_data.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1621   +/-   ##
=======================================
  Coverage   81.47%   81.48%           
=======================================
  Files          98       98           
  Lines        7282     7290    +8     
=======================================
+ Hits         5933     5940    +7     
- Misses       1349     1350    +1     
Flag Coverage Δ
unittests 81.48% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slundqui slundqui merged commit 7ec073d into delvtech:main Jul 23, 2024
5 checks passed
@slundqui slundqui deleted the precision-loss-bug branch July 23, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants