Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add interface functions for calculating market estimates #1622

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

dpaiton
Copy link
Member

@dpaiton dpaiton commented Jul 24, 2024

  • updates interface for latest hyperdrivepy (including some changes to fn signatures)
  • adds calculate_market_value_* functions

We will want to follow up with a PR that uses these functions in chainsync to compute the unrealized gains.

@dpaiton dpaiton linked an issue Aug 1, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.14%. Comparing base (f022de7) to head (e2e84d3).

Files Patch % Lines
...gent0/ethpy/hyperdrive/interface/read_interface.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1622      +/-   ##
==========================================
- Coverage   81.27%   81.14%   -0.14%     
==========================================
  Files          98       98              
  Lines        7339     7351      +12     
==========================================
  Hits         5965     5965              
- Misses       1374     1386      +12     
Flag Coverage Δ
unittests 81.14% <91.66%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpaiton dpaiton marked this pull request as ready for review August 5, 2024 19:02
tests/min_txn_amount_test.py Show resolved Hide resolved
@dpaiton dpaiton merged commit 20578ba into main Aug 5, 2024
5 checks passed
@dpaiton dpaiton deleted the dpaiton/add-rust-fns branch August 5, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync rust & interface
2 participants