Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support morpho pools in interface. Includes update to hyperdrive v1.0.16 #1625

Merged
merged 10 commits into from
Jul 24, 2024

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Jul 24, 2024

This allows us to run invariance checks on morpho pools on mainnet.

  • Adding enum variable to interface to determine hyperdrive kind.
  • Updating to hyperdrive v1.0.16.
  • Adding Morpho abi to packages/external/.
    • TODO pypechain fails on building on this contract, so we put it as an external abi, and directly feed this abi to web3.contract
  • Specific handling of getting vault shares from the morpho contract.
  • Using kind instead of vault symbol to match hyperdrive type

@slundqui slundqui changed the title Support morpho pools in interface. Includes update to hyperdrive v1.0.6 Support morpho pools in interface. Includes update to hyperdrive v1.0.16 Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 16 lines in your changes missing coverage. Please review.

Project coverage is 81.56%. Comparing base (97657a7) to head (f8e92a7).
Report is 78 commits behind head on main.

Files with missing lines Patch % Lines
...gent0/ethpy/hyperdrive/interface/read_interface.py 63.63% 12 Missing ⚠️
...ent0/ethpy/hyperdrive/interface/_contract_calls.py 75.00% 3 Missing ⚠️
...rfuzz/unit_fuzz/fuzz_long_short_maturity_values.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1625      +/-   ##
==========================================
- Coverage   81.59%   81.56%   -0.04%     
==========================================
  Files          98       98              
  Lines        7291     7327      +36     
==========================================
+ Hits         5949     5976      +27     
- Misses       1342     1351       +9     
Flag Coverage Δ
unittests 81.56% <71.42%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slundqui slundqui enabled auto-merge (squash) July 24, 2024 22:07
Copy link
Member

@ryangoree ryangoree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@slundqui slundqui merged commit de4c9a7 into delvtech:main Jul 24, 2024
5 checks passed
Copy link
Contributor

@wakamex wakamex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to have a general approach to different kinds of hyperdrive

@slundqui slundqui deleted the error-catch-symbol-call branch July 24, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants