Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethpy interface fixes #1645

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Aug 8, 2024

  • Adds cache to getting read interface from read write interface.
  • Adds known (but no special handling) hyperdrive kinds to read write interface.

Copy link
Contributor

@wakamex wakamex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some day we may want to import the HyperdriveKind enum outside of read_interface.py in which case defining it separately would be nice, but that day isn't today

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.62%. Comparing base (33ed861) to head (cc61dd8).

Files Patch % Lines
...gent0/ethpy/hyperdrive/interface/read_interface.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1645      +/-   ##
==========================================
+ Coverage   81.33%   81.62%   +0.28%     
==========================================
  Files          98       98              
  Lines        7406     7412       +6     
==========================================
+ Hits         6024     6050      +26     
+ Misses       1382     1362      -20     
Flag Coverage Δ
unittests 81.62% <83.33%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slundqui slundqui merged commit ef284d2 into delvtech:main Aug 9, 2024
5 checks passed
@slundqui slundqui deleted the read-interface-cache branch August 9, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants