Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax prev checkpoint invariance check #1649

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Aug 15, 2024

Only check if prev checkpoint exists if there are longs/shorts outstanding

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.52%. Comparing base (1643282) to head (76ca03d).

Files Patch % Lines
...c/agent0/hyperfuzz/system_fuzz/invariant_checks.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1649      +/-   ##
==========================================
- Coverage   81.54%   81.52%   -0.02%     
==========================================
  Files          98       98              
  Lines        7412     7410       -2     
==========================================
- Hits         6044     6041       -3     
- Misses       1368     1369       +1     
Flag Coverage Δ
unittests 81.52% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slundqui slundqui merged commit 9279915 into delvtech:main Aug 16, 2024
4 of 5 checks passed
@slundqui slundqui deleted the relax-prev-checkpoint branch August 16, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants