Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit types for columns, and formatting numbers with precision #1655

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

slundqui
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (9d30822) to head (47094c3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1655      +/-   ##
==========================================
- Coverage   82.33%   81.93%   -0.40%     
==========================================
  Files          98       98              
  Lines        7465     7472       +7     
==========================================
- Hits         6146     6122      -24     
- Misses       1319     1350      +31     
Flag Coverage Δ
unittests 81.93% <100.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dpaiton dpaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah

@slundqui slundqui merged commit 72ae461 into delvtech:main Aug 20, 2024
5 checks passed
@slundqui slundqui deleted the dashboard-column-types branch August 20, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants