Mazygio/tests/utils #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentilesdal
requested changes
Dec 2, 2022
There was a problem hiding this comment.
This code is SO clean. Nice work Mazy. I left some comments about testing unhappy paths, which are arguably more important to test than the happy paths. Its crucial to know when and how a method will break. This isn't as important for the simpler utils like in time.py, but a good rule of thumb is that you want to test any asserts/exceptions you see in the function. also try to test things that don't make sense so we can see how it fails and verify to ourselves that the failure is graceful or breaks in a predictable/desired manner.
MazyGio
force-pushed
the
mazygio/tests/utils
branch
2 times, most recently
from
9777ef7
to
a51a51b
Compare
dpaiton
reviewed
Dec 7, 2022
dpaiton
reviewed
Dec 7, 2022
dpaiton
reviewed
Dec 7, 2022
dpaiton
force-pushed
the
mazygio/tests/utils
branch
from
3566d22
to
06e1d7b
Compare
sentilesdal
approved these changes
Dec 7, 2022
dpaiton
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for utils/price.py and utils/parse_config.py
Cleaned up comments in utils/price.py
Added tests for utils/price.py
Cleaned up comments in utils/time.py
Added tests for utils/time.py
TODO: add tests for outputs.py and data.py