Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages to latest #227

Merged
merged 19 commits into from
Nov 9, 2021
Merged

Update packages to latest #227

merged 19 commits into from
Nov 9, 2021

Conversation

Padraic-O-Mhuiris
Copy link
Contributor

@Padraic-O-Mhuiris Padraic-O-Mhuiris commented Nov 4, 2021

This PR updates all dependent packages to latest which improves dev quality of life and better features like eip1559 compatibility in hardhat and structs-as-types from typechain.

There was one gnarly issue in regards to module-aliasing which we utilise for easier importing of typechain modules. The best solution I could come up with was relabeling our top level "typechain" directory to "typechain-types". The standard method for this as defined by hardhat was to use the tsconfig-paths for this as defined in the hardhat docs. This too ran into issues so the renaming to "typechain-types" is preferable for now

Nvm, fixed

@coveralls
Copy link

coveralls commented Nov 4, 2021

Coverage Status

Coverage remained the same at 94.454% when pulling 9d50c97 on pm/update-hardhat-v2 into 6603455 on main.

@Padraic-O-Mhuiris Padraic-O-Mhuiris marked this pull request as ready for review November 4, 2021 21:59
Copy link
Contributor

@aleph-v aleph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, should improve our whole sc flow. Please remove the test trades file before merging, though.

@Padraic-O-Mhuiris Padraic-O-Mhuiris merged commit 1611fdd into main Nov 9, 2021
@Padraic-O-Mhuiris Padraic-O-Mhuiris deleted the pm/update-hardhat-v2 branch November 9, 2021 13:34
Padraic-O-Mhuiris added a commit that referenced this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants