Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry Updates #1162

Merged
merged 7 commits into from
Sep 8, 2024
Merged

Registry Updates #1162

merged 7 commits into from
Sep 8, 2024

Conversation

jalextowle
Copy link
Contributor

Description

This PR updates the registry to support deterministic deployments using CREATE3.

@coveralls
Copy link
Collaborator

coveralls commented Sep 7, 2024

Pull Request Test Coverage Report for Build 10755794896

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 89.674%

Totals Coverage Status
Change from base Build 10711172882: 0.1%
Covered Lines: 2362
Relevant Lines: 2634

💛 - Coveralls

Copy link

github-actions bot commented Sep 7, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: ca0f03d Previous: 799a60a Deviation Status
addLiquidity: min 33812 gas 33812 gas 0% 🟰
addLiquidity: avg 193035 gas 192623 gas 0.2139% 🚨
addLiquidity: max 474677 gas 474677 gas 0% 🟰
checkpoint: min 40338 gas 40338 gas 0% 🟰
checkpoint: avg 147727 gas 147755 gas -0.0190%
checkpoint: max 259386 gas 259386 gas 0% 🟰
closeLong: min 31390 gas 31390 gas 0% 🟰
closeLong: avg 130060 gas 129895 gas 0.1270% 🚨
closeLong: max 2539405 gas 2539405 gas 0% 🟰
closeShort: min 31378 gas 31378 gas 0% 🟰
closeShort: avg 124929 gas 124815 gas 0.0913% 🚨
closeShort: max 277335 gas 277300 gas 0.0126% 🚨
initialize: min 31356 gas 31356 gas 0% 🟰
initialize: avg 355861 gas 355833 gas 0.0079% 🚨
initialize: max 424801 gas 424766 gas 0.0082% 🚨
openLong: min 33370 gas 33370 gas 0% 🟰
openLong: avg 173936 gas 173932 gas 0.0023% 🚨
openLong: max 339778 gas 339743 gas 0.0103% 🚨
openShort: min 33936 gas 33936 gas 0% 🟰
openShort: avg 172633 gas 172560 gas 0.0423% 🚨
openShort: max 415052 gas 415068 gas -0.0039%
redeemWithdrawalShares: min 31240 gas 31240 gas 0% 🟰
redeemWithdrawalShares: avg 75036 gas 74756 gas 0.3746% 🚨
redeemWithdrawalShares: max 311225 gas 311190 gas 0.0112% 🚨
removeLiquidity: min 31246 gas 31246 gas 0% 🟰
removeLiquidity: avg 215500 gas 216426 gas -0.4279%
removeLiquidity: max 403683 gas 403683 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@mcclurejt mcclurejt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

test/units/registry/HyperdriveRegistry.t.sol Outdated Show resolved Hide resolved
.env_template Outdated Show resolved Hide resolved
.env_template Outdated Show resolved Hide resolved
@jalextowle jalextowle enabled auto-merge September 8, 2024 01:02
@jalextowle jalextowle added this pull request to the merge queue Sep 8, 2024
Merged via the queue into main with commit f1a518d Sep 8, 2024
34 checks passed
@jalextowle jalextowle deleted the jalextowle/deploy/linea branch September 8, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants