Addressed a front-running vulnerability in the matching engine #1228
+309
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
requested review from
jrhea,
mcclurejt,
cashd,
sentilesdal,
dpaiton and
slundqui
as code owners
jalextowle
changed the base branch from
main
to
jalextowle/fix/on-morpho-callback-caller
Pull Request Test Coverage Report for Build 12361837408Details
💛 - Coveralls |
|
Talked to Alex offline for some questions wrt this change. The PR looks good |
mcclurejt
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows traders to set a counterparty and fee recipient for their trade. This prevents front-running that could violate the trader's intentions. These parameters are optional and will be ignored if they are set to
address(0).