Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pre commit -a #33644

Merged
merged 34 commits into from
Apr 3, 2024
Merged

fix pre commit -a #33644

merged 34 commits into from
Apr 3, 2024

Conversation

ilaner
Copy link
Contributor

@ilaner ilaner commented Mar 31, 2024 •
edited
Loading

Fix issues with pre-commit -a

  • removed reduntant tests which were different in every env
  • added type ignore for mypy
  • skipped validate-content-paths for nightly
  • added pre-commit bucket upload (allowed to fail)

nightly link: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/928592

@ilaner ilaner requested a review from israelpoli March 31, 2024 08:52
@ilaner ilaner marked this pull request as ready for review March 31, 2024 08:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Base/Scripts/SanePdfReport
   SanePdfReport.py1351588%65–66, 80, 108, 190, 208–212, 214–218
Packs/CommonScripts/Scripts/ConvertFile
   ConvertFile.py751185%52–55, 58–59, 70, 80–81, 96, 103
Packs/CommonScripts/Scripts/DockerHardeningCheck
   DockerHardeningCheck.py1707555%21–24, 30, 49–57, 60–65, 67, 70–74, 76–77, 80, 98–100, 106, 113–115, 119–121, 123, 127–132, 159, 167, 184–185, 197–198, 208–218, 244–254, 260
TOTAL38010173% 

Tests Skipped Failures Errors Time
6 0 💤 0 ❌ 0 🔥 8.925s ⏱️

@ilaner ilaner added docs-approved nightly-ok Indicates nightly was ran successfully labels Apr 3, 2024
@ilaner ilaner merged commit 21827a8 into master Apr 3, 2024
24 of 25 checks passed
@ilaner ilaner deleted the fix_pre_commit-a branch April 3, 2024 18:55
israelpoli pushed a commit that referenced this pull request May 15, 2024
@ilaner
fix pre commit -a (#33644)
f120550
israelpoli pushed a commit that referenced this pull request May 15, 2024
@ilaner
fix pre commit -a (#33644)
106239b
pal-xmco pushed a commit to pal-xmco/content that referenced this pull request Jun 19, 2024
@ilaner @pal-xmco
fix pre commit -a (demisto#33644)
7a5a8fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorschw dorschw dorschw approved these changes

@israelpoli israelpoli Awaiting requested review from israelpoli

@yucohen yucohen Awaiting requested review from yucohen

Assignees
No one assigned
Labels
docs-approved nightly-ok Indicates nightly was ran successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilaner @dorschw