Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding validation for playbook image #4538

Merged
merged 19 commits into from
Oct 21, 2024
Merged

Adding validation for playbook image #4538

merged 19 commits into from
Oct 21, 2024

Conversation

edik24
Copy link
Contributor

@edik24 edik24 commented Sep 9, 2024

Related Issues

fixes: issue

Description

Add a validation that will check that if a playbook exists in the PR, than search for a non empty image section and that a link is provided. Won't check the validity of the image. Check for image link format.
For example in this PR there are playbooks images in the directory doc_files.

@edik24 edik24 changed the title Adding valiraion for playbook image Adding validation for playbook image Sep 9, 2024
YuvHayun
YuvHayun previously requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gj!
See my commets.

.changelog/4538.yml Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/sdk_validation_config.toml Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/tests/RM_validators_test.py Show resolved Hide resolved
demisto_sdk/commands/validate/tests/RM_validators_test.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/validators/RM_validators/RM116_missing_playbook_image.py Show resolved Hide resolved
demisto_sdk/commands/validate/validators/RM_validators/RM116_missing_playbook_image.py Show resolved Hide resolved
demisto_sdk/commands/validate/validators/RM_validators/RM116_missing_playbook_image.py Show resolved Hide resolved
demisto_sdk/commands/validate/tests/RM_validators_test.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/tests/RM_validators_test.py Outdated Show resolved Hide resolved
demisto_sdk/commands/validate/tests/RM_validators_test.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Added RM116 validation to the new validate flow. The validation ensure that every playbook has an image and that the image is located under doc_files folder. #4538

ShahafBenYakir
ShahafBenYakir reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this validation run always? i.e -a and -i/g?

demisto_sdk/commands/content_graph/parsers/related_files.py Outdated Show resolved Hide resolved
@edik24
Copy link
Contributor Author

edik24 commented Sep 15, 2024

Does this validation run always? i.e -a and -i/g?

yes, always

edik24 and others added 3 commits September 24, 2024 18:15
@edik24
Merge branch 'master' into rm116
1af3fe3
@edik24
fixing validations
f580bd1
@edik24
Merge remote-tracking branch 'origin/rm116' into rm116
9b3ef22 
# Conflicts:
#	demisto_sdk/commands/validate/validators/RM_validators/RM116_missing_playbook_image.py
@github-actions GitHub Actions
Copy link

Changelog(s) in markdown:

  • Added RM116 validation to the new validate flow. The validation ensure that every playbook has an image and that the image is located under doc_files folder. #4538

@edik24 edik24 removed the request for review from YuvHayun October 15, 2024 11:58
@ShahafBenYakir ShahafBenYakir dismissed YuvHayun’s stale review October 21, 2024 08:04

Yuval already approved

@edik24 edik24 merged commit f4318b4 into master Oct 21, 2024
25 checks passed
@edik24 edik24 deleted the rm116 branch October 21, 2024 08:19
@samuelFain samuelFain mentioned this pull request Oct 29, 2024
Merged
@content-bot content-bot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShahafBenYakir ShahafBenYakir ShahafBenYakir approved these changes

@YuvHayun YuvHayun YuvHayun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edik24 @ShahafBenYakir @YuvHayun