Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for xsoar 8/xsiam configuration #53

Conversation

barryyosi-panw
Copy link
Contributor

@barryyosi-panw barryyosi-panw commented Apr 3, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Supporting XSOAR NG/ XSIAM env vars setting.

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2024

CLA assistant check
All committers have signed the CLA.

@@ -86,7 +87,7 @@ If the `license/cla` status check remains on *Pending*, even though all contribu

* `npm install`
* `npm run compile`
* `pip demisto-sdk`
* `pip install demisto-sdk`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

await vscode.window
.showInputBox({
title: "XSIAM Auth ID",
ignoreFocusOut: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add ignorefocusout to all input boxes here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@ilaner ilaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@barryyosi-panw barryyosi-panw removed the request for review from thefrieddan1 April 9, 2024 06:50
@barryyosi-panw
Copy link
Contributor Author

@ilaner Please force merge

@ilaner ilaner merged commit a523217 into master Apr 11, 2024
1 of 2 checks passed
@ilaner ilaner deleted the ciac-6603/adapt-xsoar-coonnection-config-dialog-to-select-xsoar-version branch April 11, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants