-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for xsoar 8/xsiam configuration #53
Support for xsoar 8/xsiam configuration #53
Conversation
@@ -86,7 +87,7 @@ If the `license/cla` status check remains on *Pending*, even though all contribu | |||
|
|||
* `npm install` | |||
* `npm run compile` | |||
* `pip demisto-sdk` | |||
* `pip install demisto-sdk` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
await vscode.window | ||
.showInputBox({ | ||
title: "XSIAM Auth ID", | ||
ignoreFocusOut: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add ignorefocusout to all input boxes here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job!
@ilaner Please force merge |
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Supporting XSOAR NG/ XSIAM env vars setting.
Does it break backward compatibility?