Fix handle conditions #173
Conversation
…s, we do need the OPERATORS 'IS NULL' and 'IS NOT NULL' and since they are only available in the condition without values, some filters are not working anymore
…s, we do need the OPERATORS 'IS NULL' and 'IS NOT NULL' and since they are only available in the condition without values, some filters are not working anymore
…s, we do need the OPERATORS 'IS NULL' and 'IS NOT NULL' and since they are only available in the condition without values, some filters are not working anymore
| if (array_key_exists(DrupalFilterParser::VALUE, $condition )) { | ||
| if (!array_key_exists(DrupalFilterParser::OPERATOR, $condition ) | ||
| || ($condition[DrupalFilterParser::OPERATOR] !== 'IS NULL' | ||
| && $condition[DrupalFilterParser::OPERATOR] !== 'IS NOT NULL')) { | ||
| return $this->drupalConditionFactory->createConditionWithValue($operatorName, $condition[DrupalFilterParser::VALUE], $path); | ||
| } | ||
| } |
There was a problem hiding this comment.
Handling specific operators is not the responsibility of this class. You can pass any implementation of DrupalConditionFactoryInterface into this class' constructor to support any operator with any value as you desire.
Such implementation can be done outside of this library as it depends on the specific use case and filters you want to support, which should not be coupled to this library.
There was a problem hiding this comment.
just some information about why this came up...
We can fix this issue outside of EDT. This was still a BC introduced by splitting this method so maybee it is not intended.
There was a problem hiding this comment.
How do you intend to handle the value unassigned in this example?
There was a problem hiding this comment.
There is no need for this value 'unassigned' appart from informing the FE about there filterChoice and we tried removing it.
If the value is not set - we get a constraint violation within the drupalFilterValidator that complains about a missing Value. But that means the condition to call the method createConditionWithoutValue cant be met.
There was a problem hiding this comment.
If the value is not set - we get a constraint violation within the drupalFilterValidator
@MoritzMandler: In that case I'd like to verify the correct behavior of DrupalFilterValidator. From what you wrote I deduced the following test case. It succeeds in my environment, though I'm not sure regarding the exact branch you're on. Could you please adjust it based on your actual observations, so that the mentioned constraint violation is thrown?
$factory = new PredefinedDrupalConditionFactory(
new DqlConditionFactory()
);
$validator = new DrupalFilterValidator(
Validation::createValidator(),
$factory
);
$validator->validateFilter([
"foo" => [
"condition" => [
"path" => "assignee",
"operator" => "IS NULL"
]
]
]);There was a problem hiding this comment.
Thanks a lot for your help.
We found out that the request was falsely structured after removing the value 'unassigned'.
By fixing it everything works fine without the need to change the EDT stock behavior.
Here was the wrong format that gave us these headaches...
|
this changes are not required anymore, this will be handled in core |
Ticket: https://demoseurope.youtrack.cloud/issue/DPLAN-12254/Filter-Bearbeiter-Nicht-zugewiesen-funktioniert-nicht
Description: in some cases however conditions do have values, we do need the OPERATORS 'IS NULL' and 'IS NOT NULL' and since they are only available in the condition without values, some filters are not working anymore