Fix Using/TryFinally asyncValidation CE #271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Related to #270, I think we have some issues around our TryFinally/Using code. I have updated the CE to redirect calls to the necessary
async
functions to try to fix the related issues. I think the code was originally written this way because I was referencing thevalidation
CE rather than also paying attention to thingsasyncResult
was doing.Types of changes
What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an
x
in the boxes that apply and remove ones that don't applyChecklist
Further comments
I am open to suggestions on additional unit tests we could potentially include to catch issues like this. I also added the
#if !FABLE_COMPILER && NETSTANDARD2_1
conditional on a unit test since I noticed it was inasyncResult
and notasyncValidation