Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to FT.CREATE PREFIX Parameter #17

Merged
merged 12 commits into from
Apr 16, 2021

Conversation

regisoliveira
Copy link
Contributor

Support to FT.CREATE using PREFIX {count} {prefix} parameter.
https://oss.redislabs.com/redisearch/Commands/#ftcreate

Copy link
Owner

@dengliming dengliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me. I will update the test later. Can you revert the version in pom.xml?

redistimeseries/pom.xml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #17 (89d78e0) into master (be0deea) will decrease coverage by 0.20%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #17      +/-   ##
============================================
- Coverage     60.44%   60.24%   -0.21%     
- Complexity      415      416       +1     
============================================
  Files            83       83              
  Lines          1575     1582       +7     
  Branches        135      136       +1     
============================================
+ Hits            952      953       +1     
- Misses          540      545       +5     
- Partials         83       84       +1     
Impacted Files Coverage Δ Complexity Δ
...ing/redismodule/redisearch/index/IndexOptions.java 43.75% <25.00%> (-5.04%) 15.00 <4.00> (+1.00) ⬇️
...ming/redismodule/redisearch/protocol/Keywords.java 100.00% <100.00%> (ø) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0deea...89d78e0. Read the comment docs.

@dengliming dengliming merged commit 81d0948 into dengliming:master Apr 16, 2021
@dengliming dengliming added enhancement New feature or request RediSearch labels Apr 16, 2021
@regisoliveira regisoliveira deleted the FT.CREATE_Prefix_Support branch April 18, 2021 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request RediSearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants